Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use extractions/netrc to configure GitHub API authentication #2078

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

cgrindel
Copy link
Contributor

No description provided.

@cgrindel cgrindel self-assigned this Dec 11, 2023
@cgrindel cgrindel marked this pull request as ready for review December 12, 2023 16:11
@cgrindel cgrindel requested a review from avdv as a code owner December 12, 2023 16:11
@cgrindel cgrindel added the merge-queue merge on green CI label Dec 12, 2023
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and since we only use github tokens as password, we should not be effected by extractions/netrc#4

@mergify mergify bot merged commit b833391 into master Dec 12, 2023
49 checks passed
@mergify mergify bot deleted the cg/use_action_for_gh_api_auth branch December 12, 2023 16:21
@mergify mergify bot removed the merge-queue merge on green CI label Dec 12, 2023
@cgrindel
Copy link
Contributor Author

since we only use github tokens as password, we should not be effected by extractions/netrc#4

@avdv Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants